Uli Schlachter <[email protected]> writes:

> Having written the above, I wonder if the first argument should be a struct
> xcb_extension_t instead of a major number. I think that this would be the 
> first
> function to use a major number like this and it is trivial for the
> implementation to turn the xcb_extension_t into a major number.

That's a good change, removing a bit of code an a few variables from
each call site.

> Oh and: Could you please add if(!se) return; to this function? This could
> simplify the error handling of library users.

Sure.

>
> With this change applied:
>
> Stop listening for a special event. This undoes the effect of
> xcb_register_for_special_xge().
> @param c The xcb connection.
> @param se A value returned from xcb_register_for_special_xge(). NULL is 
> allowed

-- 
[email protected]

Attachment: pgpPu9vvZ1SJw.pgp
Description: PGP signature

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to