Hi, On 02/11/2014 06:55 AM, Peter Hutterer wrote: > On Tue, Feb 04, 2014 at 12:49:14PM +0100, Hans de Goede wrote: >> The OdevAttributes struct should just be a head of the attributes list, and >> not contain various unrelated flags. Instead add a flags field to >> struct xf86_platform_device and use that. > > You just introduced int-type attributes, any reason you didn't just move > this into an attribute?
Because it is a server internal thing, not a constant value (as all other attributes are), and because having a flags field is also quite useful for later changes, for keeping track of the dri node being paused or not (which again is a server internal non const value). Regards, Hans _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel