Hi, On 02/18/2014 11:37 PM, Dave Airlie wrote: >> >> Thanks for the review! >> >>> I'm not systemd-logind aware enough to know about the rest yet, >>> >>> Well we already have a number of flags from video drivers probing, >>> like the needs hw one etc, do you need >>> to have a separate capabilities field in the driver? >> > > sorry about delay, I'm not really sure I've a good opinion here on how to go, > > but what about driverFunc, can't you use that to get flags back from > the driver before probe?
Ah yes, that would work, I did not know about that one. So I see 2 options here, either add a new HW_SUPPORT_SERVER_FD flag, which would be a bit weird API wise, or add a new SUPPORTS_SERVER_FDS xorgDriverFuncOp, which simply returns TRUE if the driver supports server fds. I've a preference for the latter, so if I don't hear anything from you that is what I'll go and implement. > We use that now to send some flags from the drivers back to the server. > > though I'm quite happy to accept that everyone should handle server-fds, > just make sure the driver authors know what to change to make it work. I think it would be best for drivers to opt-in to server-fds, esp. taking things like the blobs into consideration. With your driverFunc idea that should be a simple follow-up patch on top of my existing patches. I'm going vacation for a week next-week, after that I'll post a pull-req for my existing already reviewed patches (seems poor style todo that just before going on vacation in case my work causes any issues), and post a new patch adding support for drivers to advertise that they support server-fds. I'll also throw some docs on what drivers need to do to support server-fds into that patch. > and port -modesetting :) Yes I've already dug-up my usb displaylink laptop dock to test this :) And I'll also take care of adding support for server fds to -intel, -ati and -nouveau. Regards, Hans _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel