Keith Packard <[email protected]> writes: > Markus Wick <[email protected]> writes: > >> The max size of renderbuffers and texture often match by accident, but as we >> always use textures, we should check for the right flag. >> Also check for viewport size as this may be lower and we want to >> render to almost every pixmap. > > Using the max texture size seems completely sensible. However, I'm not > sure we need to check the view port size as that is guaranteed to be > larger than the display or the largest renderbuffer image which can be > attached to a frame buffer. I realize it says only 'renderbuffer' here, > and not something that encompasses both renderbuffers and textures, and > so I think we need a gl spec interpreter to help disambiguate. In any > case, it would be "insane" for viewports to be smaller than the largest > texture which can be drawn to...
I think we would need to check either max texture and renderbuffer, or texture and viewport. I can definitely imagine implementations where renderbuffer < texture, but it's hard to imagine an implementation where renderbuffer != viewport. I've put my r-b on this patch (and the previous one).
pgpwaXec8Zhxb.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
