On Tue, Aug 12, 2014 at 04:25:58PM -0700, Keith Packard wrote: > Thomas Klausner <[email protected]> writes: > > > From: Joerg Sonnenberger <[email protected]> > > > > Signed-off-by: Thomas Klausner <[email protected]> > > > > --- > > hw/xfree86/os-support/bsd/ppc_video.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/xfree86/os-support/bsd/ppc_video.c > > b/hw/xfree86/os-support/bsd/ppc_video.c > > index 947a686..3fd28c3 100644 > > --- a/hw/xfree86/os-support/bsd/ppc_video.c > > +++ b/hw/xfree86/os-support/bsd/ppc_video.c > > @@ -76,7 +76,7 @@ ppcMapVidMem(int ScreenNum, unsigned long Base, unsigned > > long Size, int flags) > > (flags & VIDMEM_READONLY) ? > > PROT_READ : (PROT_READ | PROT_WRITE), MAP_SHARED, fd, > > Base); > > if (base == MAP_FAILED) > > - FatalError("%s: could not mmap screen [s=%x,a=%x] (%s)", > > + FatalError("%s: could not mmap screen [s=%lx,a=%lx] (%s)", > > I inspected the code and this change appears right, but I can't compile it. > > Reviewed-by: Keith Packard <[email protected]>
Thanks for the review, modified patch email attached. It's my first xserver patch, so how do I proceed to get it included? I was told NOT to push there :) Thomas
>From 8b0bc274d3f77dda32db01274b78fb754a179caf Mon Sep 17 00:00:00 2001 From: Joerg Sonnenberger <[email protected]> Date: Mon, 11 Aug 2014 10:36:01 +0200 Subject: [PATCH] Fix format string. Reviewed-by: Keith Packard <[email protected]> Signed-off-by: Thomas Klausner <[email protected]> --- hw/xfree86/os-support/bsd/ppc_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/os-support/bsd/ppc_video.c b/hw/xfree86/os-support/bsd/ppc_video.c index 947a686..3fd28c3 100644 --- a/hw/xfree86/os-support/bsd/ppc_video.c +++ b/hw/xfree86/os-support/bsd/ppc_video.c @@ -76,7 +76,7 @@ ppcMapVidMem(int ScreenNum, unsigned long Base, unsigned long Size, int flags) (flags & VIDMEM_READONLY) ? PROT_READ : (PROT_READ | PROT_WRITE), MAP_SHARED, fd, Base); if (base == MAP_FAILED) - FatalError("%s: could not mmap screen [s=%x,a=%x] (%s)", + FatalError("%s: could not mmap screen [s=%lx,a=%lx] (%s)", "xf86MapVidMem", Size, Base, strerror(errno)); return base; -- 1.9.4
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
