Am 13.08.2014 09:54, schrieb Keith Packard: > Thomas Klausner <[email protected]> writes: > >> It's my first xserver patch, so how do I proceed to get it included? I >> was told NOT to push there :) > > You're done; it's on the list and has review, so I'll merge it to the > server. > >> Thomas >> From 8b0bc274d3f77dda32db01274b78fb754a179caf Mon Sep 17 00:00:00 2001 >> From: Joerg Sonnenberger <[email protected]> >> Date: Mon, 11 Aug 2014 10:36:01 +0200 >> Subject: [PATCH] Fix format string. >> >> Reviewed-by: Keith Packard <[email protected]> >> Signed-off-by: Thomas Klausner <[email protected]> >> --- >> hw/xfree86/os-support/bsd/ppc_video.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/xfree86/os-support/bsd/ppc_video.c >> b/hw/xfree86/os-support/bsd/ppc_video.c >> index 947a686..3fd28c3 100644 >> --- a/hw/xfree86/os-support/bsd/ppc_video.c >> +++ b/hw/xfree86/os-support/bsd/ppc_video.c >> @@ -76,7 +76,7 @@ ppcMapVidMem(int ScreenNum, unsigned long Base, unsigned >> long Size, int flags) >> (flags & VIDMEM_READONLY) ? >> PROT_READ : (PROT_READ | PROT_WRITE), MAP_SHARED, fd, Base); >> if (base == MAP_FAILED) >> - FatalError("%s: could not mmap screen [s=%x,a=%x] (%s)", >> + FatalError("%s: could not mmap screen [s=%lx,a=%lx] (%s)", >> "xf86MapVidMem", Size, Base, strerror(errno));
I would like to ask some minor queation. the first argument is "xf86MapVidMem", i assume that should be the function name. But the function is ppcMapVidMem() maybe __func__ is better here ? That could be confusing when debugging such kind of error msg. re, wh >> return base; >> -- >> 1.9.4 >> > > > > _______________________________________________ > [email protected]: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: http://lists.x.org/mailman/listinfo/xorg-devel _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
