Eric Anholt <[email protected]> writes:

> If logic op is enabled, blending doesn't happen.

Sure, but presumably we're almost always leaving the logic op disabled
as we're using either Render or GXcopy. *not* calling glDisable for
every operation seems like it might be a good idea.

> Yeah, I was a bit bothered by doing this, because it means if we ever
> get logic ops in gles2, this check would need to be updated.  But so
> far, ephyr isn't using glamor_priv.h.  I feel an in-tree use of glamor
> private functions is fine, though.

It would probably be better to expose that function in glamor.h than use
glamor_priv.h in ephyr.

-- 
-keith

Attachment: signature.asc
Description: PGP signature

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to