On Wed, Feb 18, 2015 at 10:49:35PM -0800, Matt Turner wrote: > On Fri, Jul 12, 2013 at 3:30 AM, Thomas Klausner <[email protected]> wrote: > > Hi Alan! > > > > Thanks for the patch. I can't test myself, but have forwarded your > > patch to Michael Lorenz, who came up with the original patch. I hope > > he'll find time to test it soon. > > Thomas > > > > On Thu, Jul 11, 2013 at 11:55:00AM +0100, Alan wrote: > >> I took a quick look and it seems that this bit doesn't exist on PM3, > >> only PM2. > >> > >> Can you test this alternative patch ? > >> > >> Thanks, > >> > >> Alan. > > I just noticed this when going through some old email and checked my > Permedia docs. > > My Permedia3 and 4 docs says bit 9 "UseMonitorID" exists, same > behavior as Permedia 2.
Thanks for checking up on this. Does this mean we can commit the patch Michael suggested (attached again)? Thomas
>From e69eecd64ff559e0f4148e0d9ff3ebed2ef12f89 Mon Sep 17 00:00:00 2001 From: Michael Lorenz <[email protected]> Date: Thu, 19 Feb 2015 15:26:46 +0100 Subject: [PATCH:xf86-video-ati] Fix I2C for DDC2. When doing DDC2 on Permedia make sure to clear the USE_MONID bit in the DDCdata register so the i2c bits actually do something. Signed-off-by: Thomas Klausner <[email protected]> --- src/pm2_dac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/pm2_dac.c b/src/pm2_dac.c index 85093ff..fc4bfea 100644 --- a/src/pm2_dac.c +++ b/src/pm2_dac.c @@ -458,7 +458,8 @@ Permedia2I2CPutBits(I2CBusPtr b, int scl, int sda) { GLINTPtr pGlint = (GLINTPtr) b->DriverPrivate.ptr; int r = (pGlint->DDCBus == b) ? PMDDCData : VSSerialBusControl; - CARD32 v = GLINT_READ_REG(r) & ~(ClkOut | DataOut); + + CARD32 v = 0; if (scl > 0) v |= ClkOut; if (sda > 0) v |= DataOut; -- 2.3.0
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
