Hi,
On 17-04-15 15:07, Ray Strode wrote:
Hi,
Ray, you may want to reduce the number of context lines a bit next time
you post patches.
Nope, definitely don't. my default config produces patches with a lot
of context intentionally. I want driveby readers who aren't motivated
enough to go to the source tree to still be able to do a cursory
review from just the patches themselves.
Clearly it doesn't help with full reviews, but by making life easier
for someone casually trawling email or bugzilla, I get more eyes for
"free".
You may be making life easier for casual reviewers, but you are making life
harder for the people actually merging your patches as the chances of a conflict
increase enormously with such a large context.
Anyways, this is just my 2 usd cents.
Regards,
Hans
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
