Hi, On Fri, Apr 17, 2015 at 10:43 AM, Hans de Goede > You may be making life easier for casual reviewers, but you are making life > harder for the people actually merging your patches as the chances of a > conflict increase enormously with such a large context.
Well, we all know how to deal with small conflicts pretty effortlessly I think. And, if there are non-trivial changes to the surrounding code, then "it applies" isn't really a good approximation for "patch is still correct" anyway. I agree it's a trade off, but I think more context is usually the better way to go. You're free to disagree, of course, and that's fine. --Ray _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
