On 07.11.2015 05:52, Eric Anholt wrote: > If a pixmap isn't getting exported as a dmabuf, then we don't need to > go the GBM route for it. This should reduce normal pixmap allocation > overhead, and also lets the driver choose non-scanout formats which > may be much higher performance. > > On Raspberry Pi, where scanout isn't usable as a texture source, this > improves x11perf -copypixwin100 from about 4300/sec to 5780/sec under > xcompmgr -a, because we no longer need to upload our x11perf window to > a tiled temporary in order to render it to the screen. > > Signed-off-by: Eric Anholt <[email protected]>
[...] > + bo = gbm_bo_create(glamor_egl->gbm, width, height, > + GBM_FORMAT_ARGB8888, > +#ifdef GLAMOR_HAS_GBM_LINEAR > + (pixmap_priv->usage_shared ? GBM_BO_USE_LINEAR : 0) | > +#endif > + GBM_BO_USE_RENDERING | GBM_BO_USE_SCANOUT); This can check pixmap->usage_hint == CREATE_PIXMAP_USAGE_SHARED, no need for adding the pixmap_priv->usage_shared field. With that fixed, this patch is Reviewed-by: Michel Dänzer <[email protected]> -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
