Emil Velikov <emil.l.veli...@gmail.com> writes:

>> -BOOL serverRunning = FALSE;
>> +Bool serverRunning;
> Deliberate change ? The declaration in the headers is still using BOOL.

Oops. So many edits; I thought for a while that we'd want to use this
code to make the input thread wait for the server.

>> +extern _X_EXPORT pthread_mutex_t input_mutex;
>> +extern _X_EXPORT __thread int input_mutex_count;
>> +
> Are these really meant to be exported - a wild guess will be that the
> input drivers won't need access to these ?

Turns out they do - evdev needs to grab the input lock to handle button
emulation via a timer.

> Mildly related: any particular reason why xserver uses three different
> naming formats for its exported symbols - SymbolName, symbolName and
> symbol_name ?

Yeah, the nice thing about naming conventions is that you can pick a new
one every couple of years.

-- 
-keith

Attachment: signature.asc
Description: PGP signature

_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to