Mark Kettenis <mark.kette...@xs4all.nl> writes: > Ugh. Exporting global variables as part of the ABI is generally not > such a good idea. Perhaps it is better to use functions to acquire > and release the input mutex instead?
Yeah, it's not a performance sensitive operation, so hiding the globals in a function is a good idea. I'll leave the stub versions as static inline so I don't have to move them to the new file (inputthread.c) later, just redefine them in the header file. > Also, using TLS (i.e. __thread variables) isn't portable. That > mechanism certainly isn't supported by all platforms supported by > Xorg. I can add some autoconf magic to autodetect whether this is supported and disable threaded input where it isn't. Thanks for your comments. -- -keith
signature.asc
Description: PGP signature
_______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
