On Fri, 2016-07-15 at 09:30 -0400, Alex Deucher wrote: > On Tue, Jun 28, 2016 at 4:22 AM, Michel Dänzer <[email protected]> wrote: > > From: Michel Dänzer <[email protected]> > > > > Some games incorrectly use non-premultiplied ARGB cursor data, presumably > > because that's what Windows uses. On some hardware (and with SWcursor), > > this breaks areas of the cursor which are supposed to be transparent > > (and presumably also translucent areas, but that's less noticeable). > > > > This change checks for pixels with alpha == 0 and any non-alpha component > > != 0. If any such pixel is found, the data is assumed to be > > non-premultiplied and fixed up by multiplying the RGB components with the > > alpha component. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92309 > > Signed-off-by: Michel Dänzer <[email protected]> > > --- > > > > I'm on the fence about whether this is a good or bad idea. > > > > Pro: > > * Allows users with affected setups to play broken games > > * Less overhead than a corresponding workaround in the driver > > > > Con: > > * Makes the problem completely invisible to game developers, so once > > it's in we can probably never remove it again > > > > Opinions? > > Seems like a good idea to me. > Reviewed-by: Alex Deucher <[email protected]>
Yeah, I'm convinced. remote: I: patch #95410 updated using rev 401a8d6e1379133863e3271374dc21850d0d3cab. remote: I: 1 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/xserver 033888e..401a8d6 master -> master - ajax _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
