On 24/09/16 00:20, Aaron Plattner wrote: > On 09/22/2016 04:30 PM, Bob Terek wrote: >> On 09/21/2016 10:22 AM, Aaron Plattner wrote: >>> On 09/20/2016 02:07 AM, Eric Engestrom wrote: >>>> On Tue, Sep 20, 2016 at 01:34:40PM +0700, Antoine Martin wrote: >>>>> Signed-off-by: Antoine Martin <[email protected]> >>>> >>>> Reviewed-by: Eric Engestrom <[email protected]> >>> >>> Looks good to me too (although I'm cheating since this chunk is >>> identical to part of >>> https://patchwork.freedesktop.org/patch/41058/) >> >> Shouldn't the first 5 of Aaron's patches be applied, since they are all >> cleanup items? >> >> https://lists.x.org/archives/xorg-devel/2015-January/045395.html > > I never pushed them because they were never reviewed. Would it help if I > resent them? Yes, please re-send and I'll make sure to test and review this week.
>> Patch 6 supposedly caused a server crash, but the first 5 should be ok? > > Patch 6 was kind of controversial so I don't know if we want it anyway. IIRC, I was the one who reported a crash when I tested it - I didn't investigate it further. Sounds like Bob Terek's approach is much more complete anyway. Cheers Antoine > >> -- >> Bob Terek > _______________________________________________ > [email protected]: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: https://lists.x.org/mailman/listinfo/xorg-devel > _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
