Hi Adam, > I started writing a review of Olivier's patch and got sidetracked. I > can't really think of a good reason _not_ to generate a core if > possible, even for xfree86, and I think things look a lot simpler if we > [...]
That's definitely a move in the right direction imho, yet on further discussion with Jonas in gnome bug 790502, it appears that gnome-shell would keep the "-core" command line option to capture core dumps for glamor issues (which call FatalError() as well) and other cases where FatalError() is used like an abort() in the Xserver code. As I reckon Xwayland should not “crash and generate a core dump“ for the not so unusual Wayland socket issues (i.e. when the Wayland compositor has gone AWOL), I've sent a different patch which use a “cleaner“ exit() than calling in FatalError() for those socket issues. This doesn't go against your series, just complement it for Xwayland. BTW, Xephyr and Xnest do something similar. Cheers, Olivier _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
