On 1/20/26 05:05, Olivier Fourdan wrote:
On Tue, Jan 20, 2026 at 2:38 AM Alan Coopersmith
<[email protected]> wrote:
[…]
If so, is this the right set of commits to include & exclude? Now is the
time to rewrite history on this branch before it becomes official and
people start relying on it, if there's more changes we should drop, or
changes I dropped that people think should stay.
Found another commit [4] that needs fixing in the existing history:
commit ce6704521 - Use logical_ prefix for logical coordinate system values
That translates as commit b98cf3843 [5] in your "main" branch.
The build fails with debug enabled because the debug message uses the
width/height thare just been renamed but the commit:
../hw/xwayland/xwayland-window.c: In function
‘xwl_window_enable_viewport_for_output’:
../hw/xwayland/xwayland-window.c:451:26: error: ‘struct xwl_output’
has no member named ‘width’
451 | xwl_output->width, xwl_output->height);
| ^~
../hw/xwayland/xwayland-window.c:451:45: error: ‘struct xwl_output’
has no member named ‘height’
451 | xwl_output->width, xwl_output->height);
| ^~
A patch to apply to the commit is attached to this email.
HTH
Olivier
[4] https://gitlab.freedesktop.org/xorg/xserver/-/commit/ce6704521
[5] https://gitlab.freedesktop.org/alanc/xserver/-/commit/b98cf3843
Done:
https://gitlab.freedesktop.org/alanc/xserver/-/commit/9303c0dc50e9b81f98f937205adaa0af3ed57bd1
--
-Alan Coopersmith- [email protected]
Oracle Solaris Engineering - https://blogs.oracle.com/solaris
