Hello Chris,

On Thu, Jun 10, 2010 at 11:09 AM, Chris Ball <[email protected]> wrote:

> Hi,
>
>   > Dropping the empty line makes it easier to read (between the
>   > command the the if block).
>
> I was going to mention the same thing in my initial review, but then
> I noticed that the surrounding code in src/lx_exa.c is full of that
> extra-line style.  So, I think fitting in with the nearby context is
> more important in this case.
>

I'm unsure if I agree; I think that the coding style on this driver is a
mess and we ought to start fixing it when we change it.

-- 
Otavio Salvador                  O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854         http://projetos.ossystems.com.br
_______________________________________________
Xorg-driver-geode mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-driver-geode

Reply via email to