Just as Chris worte, I follow the old custom of the code around my patch although I thought it is better to delete that white line.
Thanks, Frank -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Andres Salomon Sent: 2010?6?11? 3:28 To: [email protected] Subject: Re: [Xorg-driver-geode] [PATCH 4/7] Put the one pixel drawing work to the server to handle On Thu, 10 Jun 2010 11:20:57 -0300 Otavio Salvador <[email protected]> wrote: > Hello Chris, > > On Thu, Jun 10, 2010 at 11:09 AM, Chris Ball > <[email protected]> wrote: > > > Hi, > > > > > Dropping the empty line makes it easier to read (between the > > > command the the if block). > > > > I was going to mention the same thing in my initial review, but then > > I noticed that the surrounding code in src/lx_exa.c is full of that > > extra-line style. So, I think fitting in with the nearby context is > > more important in this case. > > > > I'm unsure if I agree; I think that the coding style on this driver > is a mess and we ought to start fixing it when we change it. > Rather than changing a single instance of it then, I'd recommend a separate patch to remove all extraneous blank lines after comments (that sits atop of Frank's patch). _______________________________________________ Xorg-driver-geode mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-driver-geode _______________________________________________ Xorg-driver-geode mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-driver-geode
