Greetings,

It has been repeatedly requested that xf86-video-geode's default color
depth be raised to 24bpp for the LX component. However, one major
obstacle to fulfilling this request has been that the OLPC XO-1
features a very limited amount of memory.

The attached patch would implement different default color depths for
DCON-based devices than for standard Geode devices. Please note that
these defaults can always be deviated from via xorg.conf options; the
only goal with this patch is to facilitate an xorg.conf-less operation
at optimal color depth for each case.

Feedback is welcome as to whether this would be a suitable solution,
as well as alternate proposals to achieve the same result.

Martin-Éric
diff --git a/src/lx_driver.c b/src/lx_driver.c
index a17854c..e17aeaa 100644
--- a/src/lx_driver.c
+++ b/src/lx_driver.c
@@ -331,8 +331,13 @@ LXPreInit(ScrnInfoPtr pScrni, int flags)
     /* Fill in the monitor information */
     pScrni->monitor = pScrni->confScreen->monitor;
 
-    if (!xf86SetDepthBpp(pScrni, 16, 16, 16, Support24bppFb | Support32bppFb))
-	return FALSE;
+    /* Purposely limit the default OLPC pixel depth to limit memory consumption */
+    if (pGeode->Output & OUTPUT_DCON)
+       if (!xf86SetDepthBpp(pScrni, 16, 16, 16, Support24bppFb | Support32bppFb))
+          return FALSE;
+    else
+       if (!xf86SetDepthBpp(pScrni, 24, 24, 24, Support24bppFb | Support32bppFb))
+          return FALSE;
 
     switch (pScrni->depth) {
     case 8:
_______________________________________________
Xorg-driver-geode mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-driver-geode

Reply via email to