On Thu, Jul 29, 2010 at 7:18 PM, Keith Packard <[email protected]> wrote: > On Thu, 29 Jul 2010 18:53:34 -0400, Kristian Høgsberg <[email protected]> > wrote: > >> This case was missing and could cause corruption if we flush damage events >> to a client before the driver gets to submit the rendering from the >> callback chain. > > Seems like this is a good candidate for 1.9, yes? Is there a specific > bug that this helps address?
It goes with this patch to xf86-video-intel: http://lists.freedesktop.org/archives/intel-gfx/2010-July/007551.html which fixes 28438. > Also, there is one more call to FlushClient in CloseDownConnection; any > reason we shouldn't be invoking the FlushCallback there too? More from a > sense of completeness than a chance that it's going to actually matter. Yes, that sounds fine. And I just realized that we need to change the damageext handler to report damage after, so the batch buffer will already have the rendering in it, in case writing the event overflows the output buffers. I'll roll these changes into an updated patch and resend Kristian _______________________________________________ [email protected]: X.Org support Archives: http://lists.freedesktop.org/archives/xorg Info: http://lists.freedesktop.org/mailman/listinfo/xorg Your subscription address: [email protected]
