On 04/14/2010 10:08 PM, saurabh wrote: > On 04/13/2010 10:53 PM, Ben Greear wrote: >> >> The callback logic seems to pass strings by copy instead of >> by reference. I think you can gain some improvements in >> code size, and definitely gain RAM& performance improvements >> by changing as many of these as possible to 'const string&'. >> >> This might require hacking the logic that generates the XRL >> code, so it may not be trivial...I haven't looked in any >> detail yet. >> > Thanks Ben, Well I will try to look in to this , I think you are talking > about perl scripts > within xrl/scripts directory, [clnt-gen skel-gen tgt-gen > thrift-clnt-gen thrift-gen thrift-tgt-gen] > is it?
I'm not too sure. It might be that horribly complex template thing that builds callbacks methods. If I were to tackle it, I'd probably change some callback signatures to pass in const string& and then see what broke and try to work backwards from there... Thanks, Ben -- Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com _______________________________________________ Xorp-hackers mailing list [email protected] http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-hackers
