To follow up on my observations: Michael J Gruber venit, vidit, dixit 19.04.2011 08:49: [snip snip] > Sure, but "attach" does something different from what I expected. My > fault... There are 3 ways in which an image (inserted or background) or > pdf (annotated or background) can be treated: > > A) refer to (relative or absolute) location (include path in xoj) > B) include in xoj (as encoded content of an element) > C) copy file to foo.xoj.<special ending> and refer to that > C') derive a rendered version and apply C to that > > I wasn't aware of C until yesterday and thought "attach" does B. xournal > does this with "not attached" (checkbox not checked): > > annotated pdf: A, e.g. > <background type="pdf" domain="absolute" filename="/tmp/a/bend.pdf" > pageno="1" /> > > background png: A, e.g. > <background type="pixmap" domain="absolute" filename="/tmp/a/bend.png" /> > > background pdf: C', e.g. > <background type="pixmap" domain="attach" filename="bg_1.png" /> > with a rendering of the pdf in <xojname>.bg_1.png > > I'm really wondering why it's doing that (rather then referring to the pdf). > > With the "attach" checkbox checked, xournal does: > > annotated pdf: C, e.g. > <background type="pdf" domain="attach" filename="bg.pdf" pageno="1" /> > with a proper copy of the pdf > > background png: A, e.g. > <background type="pixmap" domain="absolute" filename="/tmp/a/bend.png" /> > > background pdf: C', e.g. > <background type="pixmap" domain="attach" filename="bg_1.png" /> > with a rendering of the pdf in <xojname>.bg_1.png > > That is, the "attach" checkbox does not even seem to work for > backgrounds, and xournal always does C' (attach a rendered png) for > pdf-backgrounds and A (refer to original png) for png-backgrounds.
xournalpp does it right for png-backgrounds, i.e. it does C or A depending on "attach". So it is incompatible ;) I can't get pdf-backgrounds to work - I always get "You don't have any PDF pages to select from" (Journal->Paper background->PDF) even when the "insert type" is set to PDF. Does this work when annotating only? For annotating, I have a pdf which poppler (okular) can read but xournalpp refuses (Andrea: bend.pdf). With a different, xournalpp does the right thing (C or A), so again it is incompatible... > > With the image patch for xournal, early version would do A and later > versions would do B. > > Given that situation, I'm not sure that compatibility would be the best > goal here... But in fact (and no matter what to do with the non-working > background-attach option), to be as compatible and consistent as > possible, xournalpp should never do B (xournal never did B), and > inserted images should do C (by default)! As a positive side effect, the > xml machinery would not have to deal with large binary-to-text-encoded > blobs. Also, implementing A as an option for inserted images would be > simpler then. I think the B-doing patch for xournal really lead us on a > wrong path in this respect. Compatibility is important, of course, but: - don't be compatible to bugs (you corrected some of xournal's) - don't be compatible to patched versions (when they set a wrong precedent) Just my two cents. And back to work now... Cheers, Michael ------------------------------------------------------------------------------ Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev _______________________________________________ Xournal-devel mailing list Xournal-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xournal-devel
