On Sat, Apr 23, 2011 at 4:54 AM, Andreas Butti <andreasbu...@gmail.com>wrote:
> Am 23.04.2011 03:37, schrieb Matthew Chan:
>
> Hi Andreas,
>
> Last email of the night, promise =P
>
> http://thread.gmane.org/gmane.comp.freedesktop.poppler/1130/focus=1143
>
> It looks like it's an internal poppler header. We're going to need to find
> a way around it, or the distributions won't include xournal in their repos.
> Also, if it's internal, I'm not sure how long the header will stay
> unchanged. I'm not too clear what we can do to get around it since I'm not
> familiar with it.
>
> What do you think?
>
> c) do it themselves and send us the patch
> OBVIOUSLY c) is the preferred way [image: ;-)]
>
>
> I'ts not only cairoOutputDev.h
>
> I use a lot more poppler classes.
>
>
> e.g. Poppler GLIB share only 2 parameter for searching, and had internal
> 10, so it was not working for my purpose, for PDF export I use poppler
> objects which are already parsed.
>
> If there is really a problem with these things, it will might be better to
> include Poppler in the xournal sources, because they never share all
> internal sources, and we need them for PDF export, else we have to write our
> own PDF parser library, which makes absolutely no sense and is to much work.
>
I think we might have a problem if we try and include all the poppler
sources. Fedora (and ubuntu/suse too I think) have a policy against bundling
entire libraries into a project. They need to be packaged separately. Also,
if poppler releases bug or security fixes later on, we'll need to merge them
in ourselves if we bundle the sources. It could get messy really fast.
Maybe we can write a patch to poppler that exposes those functions you need?
>
> An example: void PdfObjectWriter::writeObject(Object * obj,
> XojPopplerDocument doc)
>
> Object is an internal poppler class...
>
> The problem: Poppler don't support change PDFs, this is all written by me!
>
>
> Andreas
>
>
> Matt
>
>
>
------------------------------------------------------------------------------
Fulfilling the Lean Software Promise
Lean software platforms are now widely adopted and the benefits have been
demonstrated beyond question. Learn why your peers are replacing JEE
containers with lightweight application servers - and what you can gain
from the move. http://p.sf.net/sfu/vmware-sfemails
_______________________________________________
Xournal-devel mailing list
Xournal-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xournal-devel
