Ryan: I'm not actively involved in Xournal++ and mostly trying to stay
out of the discussion, but I'm not sure I understand the point of
refactoring the code now.
It's still evolving rapidly, Andreas is not done with the first release,
and apart from the bugs that still need to be ironed out, the only
obviously wrong thing I can see with the code is the dependencies on
poppler internals, which tend to evolve quickly. As far as I understand
this is going to be addressed.
However, it's your choice.
Denis
On 05/09/2011 05:23 AM, Ryan Lewis wrote:
> I'm not saying not ever to allocate on the heap, i'm saying you **can**
> use the stack sometimes. I also did NOT say MVC was the wrong approach,
> I just questioned if it is the right one.
>
> You shouldn't need to count your objects with macros, good design should
> not have these ambiguities. No macro can verify the correctness of the
> code.
>
> And, I am trying to refactor, I already started in XournalMain.cpp, and
> i'm looking at the monolithic Control and MainWindow objects next, it's
> hard for me to single-handedly rewrite your code, since I am still
> trying to understand what it does, so I can't "just rewrite it quietly."
> Also, if you are not interested in my changes, or if you move forward
> with major changes, this merge will be, appropriately named, a giant
> headache.
--
Denis Auroux
MIT Department of Mathematics aur...@math.mit.edu
(on leave) and
University of California, Berkeley aur...@math.berkeley.edu
Department of Mathematics Tel: 510-642-4367
817 Evans Hall # 3840 Fax: 510-642-8204
Berkeley, CA 94720-3840
------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today. Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
Xournal-devel mailing list
Xournal-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xournal-devel
