Denis Auroux twisted the bytes to say:
Denis> Hi Daniel, >> - touchscreen-as-hand-tool: Use the touchscreen as a handtool exclusively Denis> I forgot, was there an issue with the naming convention for the Denis> touchscreen device? If we can make it automagic like the wacom eraser, Denis> whose name usually contains "eraser", or if we can put a substring to Denis> match the device name in a config file entry, then I'm all in favor of Denis> putting this into the stable branch. https://github.com/dmgerman/xournal/compare/master...touchscreen-as-hand-tool The main problem is windows. In linux it is simply called "touch". But in windows (at least under gtk2) the touch is part of the core pointer. I guess it means that in windows there are not 3, but 2 different devices (it might be gtk or windows, I don't know). One solution is to disable the feature altogether from windows. Denis> No time for it right now, but I assume this is a rather small patch and Denis> I'd be interested in reviewing and including it around mid-December when Denis> things will be getting calmer at work. If in your experience it is Denis> necessary to do so, I can take care of making the substring to match to Denis> decide if something is a touch device a config file entry at the same Denis> time I review the patch and merge it. This is what I currently do: if (ui.toolno[mapping] == TOOL_HAND || (ui.touch_as_handtool && strstr(event->device->name, DEVICE_FOR_TOUCH) != NULL)) { and DEVICE_FOR_TOUCH is a constant. you should try it. The only problem is that in the X220 the touch is disabled when the pen is closed, and sometimes it feels as if the touch stops working. Denis> Of course, an even better thing would be a revamped dialog system for Denis> assigning individual buttons of individual input devices to different Denis> tools (independently or linked together) -- a bit like the current Denis> "button 2 mapping" and "button 3 mapping" submenus but per device and Denis> more user-friendly. Perhaps look at Gimp's input device dialog box, Denis> though I find it too complicated to be pleasant to use. An alternative, Denis> more hackish and less UI-intensive way of doing this (thus something I'm Denis> more likely to do :-) would be to reroute the event processing code for I'll think about this. I'll have to look at the code. Denis> the tools/colors/... toolbar so that it can be hit with any button of Denis> any device and the corresponding callbacks know about it and set things Denis> for that button of that device. Hmm, in that case we'd still need a way Denis> of linking up together devices/buttons that the user wants to see Denis> treated as "logically equivalent". You don't want the user to have to Denis> select the red pen once with the mouse and once with the touchpad and Denis> once with the pen unless they really want to -- by default one might Denis> expect one setting to affect all of them. yes :) >> - horizontal-scroll-lock: do not allow hand tool to scroll horizontally Denis> Seems useful as well (perhaps less than the previous one, but at least Denis> not a bad idea in conjunction with it). Very useful when reviewing papers in two columns mode :) --dmg Denis> Best, Denis> Denis Denis> -- Denis> Denis Auroux aur...@math.berkeley.edu Denis> University of California, Berkeley Tel: 510-642-4367 Denis> Department of Mathematics Fax: 510-642-8204 Denis> 817 Evans Hall # 3840 Denis> Berkeley, CA 94720-3840 Denis> ------------------------------------------------------------------------------ Denis> Shape the Mobile Experience: Free Subscription Denis> Software experts and developers: Be at the forefront of tech innovation. Denis> Intel(R) Software Adrenaline delivers strategic insight and game-changing Denis> conversations that shape the rapidly evolving mobile landscape. Sign up now. Denis> http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk Denis> _______________________________________________ Denis> Xournal-devel mailing list Denis> Xournal-devel@lists.sourceforge.net Denis> https://lists.sourceforge.net/lists/listinfo/xournal-devel -- Daniel M. German "You cannot have the success without H. G. Hasler -> the failures." http://turingmachine.org/ http://silvernegative.com/ dmg (at) uvic (dot) ca replace (at) with @ and (dot) with . ------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk _______________________________________________ Xournal-devel mailing list Xournal-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xournal-devel
