Sorry, I should have read all the threat before starting to reply...

 Denis Auroux twisted the bytes to say:


 Denis> I would tend to agree that you likely ran into an extremely bad case of 
 Denis> this bug that caused a gigantic shape to be created. (for the memory 
 Denis> allocation to request 3.5 GB of RAM, I think the shape would have to be 
 Denis> several billion pixels tall). Perhaps it would make sense as a 
temporary 
 Denis> fix to not let the shape recognizer produce shapes that extend well 
 Denis> beyond the area containing the strokes that were recognized and abort 
 Denis> the shape recognition if that is what the algorithm produces (i.e., if 
I 
 Denis> can't fix the underlying bug, at least avoid the rare cases where it 
 Denis> causes a crash).

One solution, Denis, would be to check the allocations. Currently none
of them if checked in case of an error (xo-shapes.c). Then the
allocation can be easily tamed for very large requests and simply return
with no collateral damage.


 Denis> Denis

--dmg



--
Daniel M. German                  "As Arthur C. Clarke didn't write,
                                   any sufficiently advanced lens
   David Pogue ->                  is indistinguishable from magic."
http://turingmachine.org/
http://silvernegative.com/
dmg (at) uvic (dot) ca
replace (at) with @ and (dot) with .

 

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Xournal-devel mailing list
Xournal-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xournal-devel

Reply via email to