In the mode where changing the active layer doesn't automatically show/hide those between the old and new active layers, ultimately one might want to change slightly the logic of on_viewShowLayer_activate() and on_viewHideLayer_activate().
(on_viewHideLayer() without change is still reasonable, because a menu entry called "Hide Layer" should do just that, and then the currently active layer should change since the active layer becomes hidden; moving down by 1 seems reasonable though you don't know completely for sure whether that layer is visible. on_viewShowLayer() is trickier because it first moves up by 1 layer and then makes that one visible, which is a bit counterintuitive, in case the new layer was already visible nothing new gets shown -- but since the currently active layer is already visible, I don't know what else "Show Layer" should be doing, except perhaps look harder for a hidden layer near the active one in case it's not the one just above that would make most sense?) Ultimately ultimately, there should just be something smarter, where one has the ability to make layers visible/invisible independently of each other, and also to change the order of layers or flatten several layers onto one. This will require more serious UI changes though. Best, Denis On 03/22/2014 08:32 PM, D M German wrote: > > One thing I'd love to have (and I just checked and it is easy to > implement) is that i can't see above layers. > > Say I have two layers (plus background). I would like to add strokes > behind the current one (say highlighter). the problem is that the > layers above are not visible. > > I suspect, Denis, that the main rational to hide upper layers is to > avoid the confusion of not being able to select. > > What I suggest is the following: > > - Create an option: Display "above" layers. Defaults to false. > > - In the following code comment the line: gnome_canvas_item_hide > I don't think there is any side effect. > > on_comboLayer_changed (GtkComboBox *combobox, > ... > while (val<ui.layerno) { > gnome_canvas_item_hide(GNOME_CANVAS_ITEM(ui.cur_layer->group)); > ui.layerno--; > if (ui.layerno<0) ui.cur_layer = NULL; > else ui.cur_layer = g_list_nth_data(ui.cur_page->layers, ui.layerno); > } > > > > -- > Daniel M. German "I'm crazy, but I'm not stupid" > Jackie Chan > http://turingmachine.org/ > http://silvernegative.com/ > dmg (at) uvic (dot) ca > replace (at) with @ and (dot) with . > > > > ------------------------------------------------------------------------------ > Learn Graph Databases - Download FREE O'Reilly Book > "Graph Databases" is the definitive new guide to graph databases and their > applications. Written by three acclaimed leaders in the field, > this first edition is now available. Download your free book today! > http://p.sf.net/sfu/13534_NeoTech > _______________________________________________ > Xournal-devel mailing list > Xournal-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/xournal-devel > -- Denis Auroux aur...@math.berkeley.edu University of California, Berkeley Tel: 510-642-4367 Department of Mathematics Fax: 510-642-8204 817 Evans Hall # 3840 Berkeley, CA 94720-3840 ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Xournal-devel mailing list Xournal-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xournal-devel