On Sun, 10 Feb 2002 [EMAIL PROTECTED] wrote:
> > Noticed this today when compiling X from CVS and fixed it as best as I
> > could.
> > Hope you like it and if not let me learn how to fix it better by telling
> > me.
> >
> > Diff attached.
> Ooops, I should have sent it as plain-text but my webmailer mime'd it.
IMHO mime'd patches are fine;
easier to save and run than cutting and pasting.
OK text can be easier when we are discussing code, rather than applying
fixes, so feel free to use whichever is more appropriate, and don't worry
about using "plain text" Mime.
> - if (islower(arguments->command))
> - arguments->command = toupper(arguments->command);
> + if (islower(arguments->command)) {
> + tmpcmd = toupper(arguments->command);
> + arguments->command = tmpcmd;
> + }
I think this is good enough:
diff -u -r1.16 format.c
--- format.c 2002/02/10 02:50:06 1.16
+++ format.c 2002/02/11 11:49:20
@@ -416,7 +416,7 @@
*code = NOERROR;
arguments->command = *ptr++;
if (islower(arguments->command))
- arguments->command = toupper(arguments->command);
+ arguments->command = toupper((int)(arguments->command));
++arguments->offset;
--
Dr. Andrew C. Aitchison Computer Officer, DPMMS, Cambridge
[EMAIL PROTECTED] http://www.dpmms.cam.ac.uk/~werdna
_______________________________________________
Xpert mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/xpert
