> > Ooops, I should have sent it as plain-text but my webmailer mime'd it.
>
> IMHO mime'd patches are fine;
> easier to save and run than cutting and pasting.
> OK text can be easier when we are discussing code, rather than applying
> fixes, so feel free to use whichever is more appropriate, and don't worry
> about using "plain text" Mime.
OK, thanks for the info. I was just worried that my web-mailer would produce
some non-standard stuff etc. That's all.
>
> > - if (islower(arguments->command))
> > - arguments->command = toupper(arguments->command);
> > + if (islower(arguments->command)) {
> > + tmpcmd = toupper(arguments->command);
> > + arguments->command = tmpcmd;
> > + }
>
> I think this is good enough:
> diff -u -r1.16 format.c
> --- format.c 2002/02/10 02:50:06 1.16
> +++ format.c 2002/02/11 11:49:20
> @@ -416,7 +416,7 @@
> *code = NOERROR;
> arguments->command = *ptr++;
> if (islower(arguments->command))
> - arguments->command = toupper(arguments->command);
> + arguments->command = toupper((int)(arguments->command));
> ++arguments->offset;
Agreed, looks better, but the pros/cons of too much casting could be
discussed for sure, though I don't want to do so and like this better as it changes
just one line and hasn't the overhead of a tmp-variable used only once.
--
GMX - Die Kommunikationsplattform im Internet.
http://www.gmx.net
_______________________________________________
Xpert mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/xpert
