On Fri, Mar 29, 2002 at 12:39:14AM -0800, Keith Packard wrote: > > I've been having troubles with Xv output on my Radeon cards (a 7500 at > home and an M6 in my laptop). The color key wasn't working, so I cribbed > some code from Gatos to fix it. The Gatos code was a bit broken, working > for only depth 16 and depth 24 TrueColor visuals, but that was easy enough > to fix. > > Diffs from current XFree86 CVS can be found at > > http://keithp.com/~keithp/download/radeon_xv.diff > > Should I commit this patch? Or is the current code actually working for > some cards? >
I did something similiar weeks ago and sent a diff to Marc La France. I should have sent it to this list too :) My patch is larger than yours, since I took more code from Gatos and added offscreen images support. It's available at http://quark.fsb.hr/vedran/xfree86/radeon/radeon_xv.diff You seem to be missing bits of code setting the RADEON_VCLK_ECP_CNTL. Without this I see only the west half of the video (stretched to scaled XvImage size) when the pixel clock threshold of 175 MHz is crossed. I don't think that this register needs to be set on every DisplayVideo() like it is in my patch and gatos currently. Maybe it can be set only when the mode actually changes? Lines 776-779 of my patch should be correct, but you don't have them in your patch. Vedran Rodic _______________________________________________ Xpert mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/xpert
