[Xpert]Invalid error checking bsd_kmod.c

[Joy Ganguly]

Hi all ,

There is a bug in
xc/programs/Xserver/hw/xfree86/os-support/bsd/bsd_kmod.c due to invalid
error checking of kldload() ( which returns -1 in case of error ) . The
diff is attached.

Thanks

Joy

#include <errno.h>
#include <fcntl.h>
#include <unistd.h>
#include <sys/param.h>
#include <sys/linker.h>

#include "xf86_OSproc.h"
#include "xf86_ansic.h"

/*
 * Load a FreeBSD kernel module.
 * This is used by the DRI/DRM to load a DRM kernel module when
 * the X server starts.  It could be used for other purposes in the future.
 * Input:
 *    modName - name of the kernel module (Ex: "tdfx")
 * Return:
 *    0 for failure, 1 for success
 */
int xf86LoadKernelModule(const char *modName)
{
    
    if (kldload(modName) != -1) 
        return 1;
    else 
        return 0;
}