Hi All I have created a branch that adds syslog support to the XRDP process. When I now run XRDP and supervise the syslog, a strange behavior has come to my attention. For each login the users perform, a sequence of doubled log events are created as indicated below. (I have removed the time and user to make it more readable.) It seems that there is some bug here, even if everything works. I have not performed any detailed debugging yet because I would like to know if anyone have any suggestions or comments. Without knowing I suspect that we have to add a mutex or semaphore somewhere?
Regarding the log output, the numbers in the parentheses are (process ID)(Thread ID). I hope that my patch in the future can simplify the process of debugging and creating bug reports. In professional use inside companies the log can also be a prerequisite for approval of the software. There are many small changes in my patch where I have removed g_writeln() and replaced them with the log equivalent log_message(). The log functions are shared between sesman an xrdp and most of the patch is actually a change, of the already existing log support used by sesman. The source for the patch can be found at: https://github.com/ArvidNorr/xrdp/commits/syslog XRDP-sesman[2264]: (2264)(2264)[DEBUG] Sesman listening loop started... XRDP[2300]: (2300)(2300)[DEBUG] Accepted new connection in trans_check_wait_objs() XRDP[2300]: (2300)(2300)[DEBUG] Accepted new connection in trans_check_wait_objs() XRDP[2300]: (2300)(2304)[DEBUG] xrdp_000008fc_wm_login_mode_event_00000002 XRDP[2300]: (2300)(2304)[WARN ] local keymap file for 0x041d found and dosen't match built in keymap, using local keymap file XRDP[2300]: (2300)(2304)[DEBUG] Connecting to sesman ip 127.0.0.1 port 3350 XRDP[2300]: (2300)(2304)[DEBUG] Connecting to sesman ip 127.0.0.1 port 3350 XRDP-sesman[2264]: (2264)(2264)[DEBUG] Sesman; new connection established XRDP-sesman[2264]: (2264)(2264)[INFO ] scp thread on sck 8 started successfully XRDP[2300]: (2300)(2304)[DEBUG] sesman connect ok XRDP[2300]: (2300)(2304)[DEBUG] sending login info to session manager, please wait... XRDP-sesman[2264]: (2264)(2307)[INFO ] ++ created session (access granted): username administrator, ip 192.168.1.75:49652 - socket: 8 XRDP-sesman[2264]: (2264)(2307)[INFO ] starting Xvnc session... XRDP[2300]: (2300)(2304)[DEBUG] xrdp_mm_process_login_response: login successful for display 10 XRDP[2300]: (2300)(2304)[DEBUG] xrdp_mm_process_login_response: login successful for display 10 Please let me know if you have any comments to the syslog patch or have any suggestions to the doubled log events Regards Arvid ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 _______________________________________________ xrdp-devel mailing list xrdp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xrdp-devel
