Steve Youngs <[EMAIL PROTECTED]> writes:

> I've cleaned up the build under XEmacs a bit.  Build the
> auto-autoloads properly, got rid of all of the undefined function
> warnings, and a couple of bound but not referenced variable warnings.

... And broke the VPATH build :-(

The Makefiles are written so that

$ mkdir what/ever
$ cd what/ever
$ /path/to/xtla/configure
$ make
$ make install

Work. It doesn't seem to be possible with your version.

Also, I'd like to keep a build system as factored as possible between
Emacs and XEmacs. Your version makes a completely different system for
the two versions (GNU Emacs would use separate compilation whereas
XEmacs would compile all files in batch, ...).

I also don't like virtual targets when targets are actually files
(e.g. I expect "cd lisp; make xtla-version.elc" to work).

So, I'm (currently) rejecting most of your changes in the Makefile.

See what I've done in
[EMAIL PROTECTED] (concatenation
of two patches), and discuss here and/or submit another patch if
you're not satisfied. (I'm not at all an expert with XEmacs ...)

Thanks for your contribution,

--
Matthieu

Reply via email to