Matthieu Moy <[EMAIL PROTECTED]> writes:

> Hi !
>
> Was there any particular reason why tla--read-directory-name had this
> piece of code :
>
>    (unless dir
>      (setq dir default-directory))
>    (unless default-dirname
>      (setq default-dirname
>         (if initial
>                (concat dir initial)
>              default-dir)))
>
> ?
>
> I think arguments can just be passed unmodified to read-file-name. As
> a user, I like to have the same behaviour in different parts of Emacs,
> so, tla--read-directory-name should really look like read-file-name,
> and as a developper, removing these lines of code also removed the bug
> of the last line ("defaul-dir" should have been "dir").
>
> I've left the code (corrected and) commented. If there's any reason to
> uncomment it, please, argue ;-)

No argument from me :o)  Actually I just pulled the function defun for
`read-directory-name' straight out of my emacs source and renamed it,
so those lines come from there.

Cheers,

Mark

-- 
Mark Triggs
<[EMAIL PROTECTED]>

Reply via email to