Masatake YAMATO <[EMAIL PROTECTED]> writes:
> It seems that tla-show-changes-buffer shows only a part of
> changesets. The code is obvious:
>
> ;; point is at middle of the buffer.
> (let ((footer (buffer-substring-no-properties
> (point) (point-max))))
>
> I fixed this codes like:
>
> (let ((footer (concat
> ;; - is a keyword for diff output.
>
> "________________________________________________________________________\n\n"
> (buffer-substring-no-properties
> (point-min) (point-max)))))
^^^^^^^^^
No, that's not what the function is supposed to do.
The principle is to parse the beginning of the buffer, up to a point
where parsing stops. The footer of the cookie is the unparsed part of
the buffer.
This is perfectly suited if the buffer is the output of "tla changes",
because the beginning of the buffer is the list of files, and the end
the concatenation of patches.
It's still buggy in some cases, in particular, parsing the output of
"tla show-changeset" is more difficult.
With your modification, tla-changes shows the list of files twice. I'm
reverting to the old version. You'll probably find bugs. Either fix
them or report them, but just concatenating the whole buffer at the
end of the list of files is not satisfying for me.
--
Matthieu
