Masatake YAMATO <[EMAIL PROTECTED]> writes:
>> This is perfectly suited if the buffer is the output of "tla changes",
>> because the beginning of the buffer is the list of files, and the end
>> the concatenation of patches.
>>
>> It's still buggy in some cases, in particular, parsing the output of
>> "tla show-changeset" is more difficult.
>
> I see. So the temporally solution is
>
> if "tla changes" is invoked (point) should be used.
Yes,
> else if "tla changesets" is invoked (point-min) should be used.
No, because higher in the code, you can see
(setq header (buffer-substring-no-properties
(goto-char (point-min))
^^^^^^^^^^^^^^^^^^^^^^^
(progn (re-search-forward "^[^*]" nil t)
^^^^^^^^^^^^^^^^^^
(beginning-of-line)
(point))))
So, it's also supposed to work. If you use (point-min), then, you will
get the header in the footer also ...
The current implementation already works for simple changesets. (Only
file addition and modification). I've just tested it. (Just committed
patch)
So, the temporary solution is to leave the code as it is, and the long
term solution is to implement the unimplemented cases ;-)
--
Matthieu
