[cc'ed xwin-discuss, since most of these are X issues - for folks seeing it
there, the code review I'm responding to can be seen at:
http://mail.opensolaris.org/pipermail/jds-review/2009-February/003857.html
mostly in the compiz-by-default script attachment at:
http://mail.opensolaris.org/pipermail/jds-review/attachments/20090204/216bee31/attachment-0003.ksh
]
> if [ "x$arch_type" = "xi86pc" ]; then
Systems running Xen/xVM aren't compiz compatible?
% /usr/bin/uname -i
i86xpv
> verbose "Checking for Intel Graphics Card Type : "
> # List taken from SUNWdrmr/postinstall
> # Confirmed list (29/01/09)
> # pci8086,2562 - compiz fails, driver problem
> # pci8086,27a2 - compiz fails, driver problem
> # pci8086,2a42 - compiz runs
> intel=`echo $prtconf_pv_output | $NAWK '{ \
I still think it's a mistake for your script to hardcode a list of
Intel & ATI chip ids, since you'll have to keep up with new ones as
they're added.
> verbose "Check Xorg Log : $xorg_log, for driver for graphics card
> $CARD_TYPE : "
> if $GREP -q "Loading $driver_path/nvidia_drv.so" $xorg_log; then
The contents of Xorg.0.log are not a stable interface, and can change without
warning at any time. "Loading" messages in Xorg.0.log do not indicate which
driver is in use, just that the module was opened - it could have failed to
attach to the hardware and unloaded.
> if [ -f $COMPOSITE_INCLUDE ]; then
> major=`$GREP "COMPOSITE_MAJOR" $COMPOSITE_INCLUDE | $NAWK '{print
> $3;}'`
> minor=`$GREP "COMPOSITE_MINOR" $COMPOSITE_INCLUDE | $NAWK '{print
> $3;}'`
The version reported in the header does not tell you anything about what the
server supports, and the header will not be installed on most OpenSolaris
systems, since the header packages are not included on the live CD, nor are they
on SXCE systems installed with "End User" instead of Developer or Full clusters.
You need to run something that calls XCompositeQueryVersion() to get the version
information. I don't know of anything off hand included in the system already
that does so and prints the result, but you could include a trivial helper
program like the one attached.
> verbose " Horizonstal resolution ($hor_res) less than
> GL_MAX_TEXTURE_SIZE($max_texture_size)."
Typo in horizontal.
--
-Alan Coopersmith- alan.coopersmith at sun.com
Sun Microsystems, Inc. - X Window System Engineering
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xcompvers.c
Type: text/x-csrc
Size: 751 bytes
Desc: not available
URL:
<http://mail.opensolaris.org/pipermail/xwin-discuss/attachments/20090204/9925acb7/attachment.bin>
