Not sure if this is answered as was posted a bit ago. I think there's 
some confusion resulting from the fact that if the Xlib i18n code resync 
with Xorg code caused the issue, but by looking at the bug it's clear 
that the issue is *rather solved after* snv_85 because of the new l18n code.

The issue seems to be a wine patch using XICCallback without proper 
checks to see if it's existing in pre snv-85 Solaris xlib.h file, and 
was failing as we did not have it, but only XIMCallback

we have

typedef struct {
    XPointer client_data;
    XIMProc callback;
} XIMCallback;

but the code needed

typedef struct {
    XPointer client_data;
    XICProc callback;
} XICCallback;

and no check was made to check XICCallback existence. With the merge 
with Xorg, we have both these XIMCallback/XICCallback defined in xlib.h 
so compilation succeeds.

For getting the XICCallback code working in Solaris 10, along with the 
configure patch for //HAVE_XICCALLBACK_CALLBACK //check if the folowing 
code put into xim.c will work. (No need to patch xim.c as in 
http://www.winehq.org/pipermail/wine-devel/2008-April/064862.html
but take configure check from that file)

#ifndef  //HAVE_XICCALLBACK_CALLBACK
//
typedef struct {
    XPointer client_data;
    XICProc callback;
} XICCallback;

typedef Bool (*XICProc)(
    XIC,
    XPointer,
    XPointer
);
#endif

Haven't tried this, let me know if it works.

Regards,
Suresh

Alan Coopersmith wrote:
> Solaris before nv_85 has a different set of i18n routines than the current
> X.Org sources.   In nv_85, the Globalization team resynced our Xlib
> i18n routines with the community - unfortunately, I have no idea what an
> XICCallback is other than it's in the i18n code, and have to defer to the
> i18n experts there (which is why I've cc'ed i18n-discuss).
>
>       -Alan Coopersmith-           alan.coopersmith at sun.com
>        Sun Microsystems, Inc. - X Window System Engineering
>
> Petr Sumbera wrote:
>   
>> Hi all,
>>
>> can anybody please comment on following Solaris related problem in Wine?
>>
>> http://www.winehq.org/pipermail/wine-devel/2008-April/064832.html
>>
>> and eventually explain why patch proposed in that thread
>> (http://www.winehq.org/pipermail/wine-devel/2008-April/thread.html#64832)
>>
>> doesn't work (tries to execute non-executable data):
>>
>> http://bugs.winehq.org/show_bug.cgi?id=12740
>>
>> Thanks,
>>
>> Petr
>>  
>>  
>> This message posted from opensolaris.org
>> _______________________________________________
>> xwin-discuss mailing list
>> xwin-discuss at opensolaris.org
>>     
>
> _______________________________________________
> i18n-discuss mailing list
> i18n-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/i18n-discuss
>   


Reply via email to