You are right on maxMultiplier, it should be improved. The consequence is that convergence to a traction state is sub-optimal (but still converging). No I don't have a test script for that.
Bruno On 03/12/14 23:20, Jerome Duriez wrote: > Obviously, I confess I did not consider isotropic traction... > > I will definitively try to improve the commit if I broke something. > Did the code, in previous state, work well for such situations ? > > Considering l.205 of TSC [1], it seems to me that, in previous state > for isotropic traction case, finalMaxMultiplier would be considered > instead of maxMultiplier in non adequate situations. > What do you think ? > > If you have a working example script that illustrates the behaviour of > the previous code in isotropic traction, it would be obviously useful > for me. > > [1] > https://github.com/yade/trunk/commit/19e81a785b19a8eab2718ebb5ad5eb9456355818#diff-e3491e9c63e91170258c65eec9377298L203 > > > ------------------------------------------------------------------------ > *From:* Yade-dev > [[email protected]] on > behalf of Bruno Chareyre [[email protected]] > *Sent:* December 3, 2014 1:42 PM > *To:* [email protected] > *Subject:* Re: [Yade-dev] [Branch ~yade-pkg/yade/git-trunk] Rev 3541: > Many changes towards a more consistent sign convention throughout the > code for stresses and strai... > > Hi Jérome, > There is a problem in this commit, see lines [1]. > You replaced: > siso = goal1 + goal2 + goal3 > by > siso = abs(goal1 + goal2 + goal3) > > So now it is impossible to define isotropic traction as a target state. > Stresses and strains have signs, there should not be any abs() > function applied on them except in a few special cases, else it breaks > the algorithms. > > Cheers. > > Bruno > > > [1] > https://github.com/yade/trunk/commit/19e81a785b19a8eab2718ebb5ad5eb9456355818#diff-e3491e9c63e91170258c65eec9377298L203 > see also: > https://github.com/yade/trunk/commit/19e81a785b19a8eab2718ebb5ad5eb9456355818#diff-e3491e9c63e91170258c65eec9377298L210 > > On 19/11/14 01:18, [email protected] wrote: >> ------------------------------------------------------------ >> revno: 3541 >> committer: jduriez <[email protected]> >> timestamp: Tue 2014-11-18 12:46:27 -0700 >> message: >> Many changes towards a more consistent sign convention throughout the code >> for stresses and strains. Should fix e.g. >> https://bugs.launchpad.net/yade/+bug/1381282. The goal is to know directly >> the meaning of a strain or stress value each time one is encountered. >> Relying on the classical Continuum Mechanics convention (editorial >> choice...). A global announcement is planned in a couple of days, in case >> some errors appear in the meantime. >> modified: >> examples/FluidCouplingPFV/oedometer.py >> examples/clumps/triax-basic-with-clumps.py >> examples/test/triax-basic.py >> examples/test/triax-cohesive.py >> examples/triax-tutorial/script-session1.py >> pkg/dem/CapillaryTriaxialTest.hpp >> pkg/dem/CohesiveTriaxialTest.hpp >> pkg/dem/TriaxialCompressionEngine.cpp >> pkg/dem/TriaxialCompressionEngine.hpp >> pkg/dem/TriaxialStressController.cpp >> pkg/dem/TriaxialStressController.hpp >> pkg/dem/TriaxialTest.hpp >> py/pack/pack.py >> scripts/checks-and-tests/checks/DEM-PFV-check.py >> scripts/checks-and-tests/checks/checkTestTriax.py >> >> >> -- >> lp:yade >> https://code.launchpad.net/~yade-pkg/yade/git-trunk >> >> Your team Yade developers is subscribed to branch lp:yade. >> To unsubscribe from this branch go to >> https://code.launchpad.net/~yade-pkg/yade/git-trunk/+edit-subscription >> >> >> _______________________________________________ >> Mailing list: https://launchpad.net/~yade-dev >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~yade-dev >> More help : https://help.launchpad.net/ListHelp > > > -- > _______________ > Bruno Chareyre > Associate Professor > ENSE³ - Grenoble INP > Lab. 3SR > BP 53 > 38041 Grenoble cedex 9 > Tél : +33 4 56 52 86 21 > Fax : +33 4 76 82 70 43 > ________________ > > > _______________________________________________ > Mailing list: https://launchpad.net/~yade-dev > Post to : [email protected] > Unsubscribe : https://launchpad.net/~yade-dev > More help : https://help.launchpad.net/ListHelp -- _______________ Bruno Chareyre Associate Professor ENSE³ - Grenoble INP Lab. 3SR BP 53 38041 Grenoble cedex 9 Tél : +33 4 56 52 86 21 Fax : +33 4 76 82 70 43 ________________
_______________________________________________ Mailing list: https://launchpad.net/~yade-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp
