** Changed in: neutron
Status: Fix Committed => Fix Released
** Changed in: neutron
Milestone: None => liberty-1
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1442377
Title:
Intermittent ipset_manager test failures in Kilo
Status in OpenStack Neutron (virtual network service):
Fix Released
Bug description:
It was brought to my attention that there is an intermittent
ipset_manager test failure in the latest Kilo code, most likely caused
by https://review.openstack.org/#/c/170328/
This is one from http://logs.openstack.org/46/149546/39/check/gate-
neutron-python27/f903ce3/console.html :
2015-04-09 18:15:35.721 | ==============================
2015-04-09 18:15:35.721 | Failed 1 tests - output below:
2015-04-09 18:15:35.721 | ==============================
2015-04-09 18:15:35.721 |
2015-04-09 18:15:35.722 |
neutron.tests.unit.agent.linux.test_ipset_manager.IpsetManagerTestCaseHashArgs.test_set_members_adding_more_than_5
2015-04-09 18:15:35.722 |
------------------------------------------------------------------------------------------------------------------
2015-04-09 18:15:35.722 |
2015-04-09 18:15:35.722 | Captured traceback:
2015-04-09 18:15:35.722 | ~~~~~~~~~~~~~~~~~~~
2015-04-09 18:15:35.722 | Traceback (most recent call last):
2015-04-09 18:15:35.722 | File
"neutron/tests/unit/agent/linux/test_ipset_manager.py", line 135, in
test_set_members_adding_more_than_5
2015-04-09 18:15:35.723 | self.verify_mock_calls()
2015-04-09 18:15:35.723 | File
"neutron/tests/unit/agent/linux/test_ipset_manager.py", line 43, in
verify_mock_calls
2015-04-09 18:15:35.723 |
self.execute.assert_has_calls(self.expected_calls, any_order=False)
2015-04-09 18:15:35.723 | File
"/home/jenkins/workspace/gate-neutron-python27/.tox/py27/local/lib/python2.7/site-packages/mock.py",
line 863, in assert_has_calls
2015-04-09 18:15:35.723 | 'Actual: %r' % (calls, self.mock_calls)
2015-04-09 18:15:35.723 | AssertionError: Calls not found.
2015-04-09 18:15:35.724 | Expected: [call(['ipset', 'create', '-exist',
'IPv4fake_sgid', 'hash:ip', 'family', 'inet', 'hashsize', '2048', 'maxelem',
'131072'], run_as_root=True, process_input=None), call(['ipset', 'restore',
'-exist'], run_as_root=True, process_input='create IPv4fake_sgid-new hash:ip
family inet hashsize 2048 maxelem 131072\nadd IPv4fake_sgid-new 10.0.0.1'),
call(['ipset', 'swap', 'IPv4fake_sgid-new', 'IPv4fake_sgid'], run_as_root=True,
process_input=None), call(['ipset', 'destroy', 'IPv4fake_sgid-new'],
run_as_root=True, process_input=None), call(['ipset', 'restore', '-exist'],
run_as_root=True, process_input='create IPv4fake_sgid-new hash:ip family inet
hashsize 2048 maxelem 131072\nadd IPv4fake_sgid-new 10.0.0.1\nadd
IPv4fake_sgid-new 10.0.0.2\nadd IPv4fake_sgid-new 10.0.0.3'), call(['ipset',
'swap', 'IPv4fake_sgid-new', 'IPv4fake_sgid'], run_as_root=True,
process_input=None), call(['ipset', 'destroy', 'IPv4fake_sgid-new'],
run_as_root=True, process_input=No
ne)]
2015-04-09 18:15:35.724 | Actual: [call(['ipset', 'create', '-exist',
'IPv4fake_sgid', 'hash:ip', 'family', 'inet', 'hashsize', '2048', 'maxelem',
'131072'], run_as_root=True, process_input=None),
2015-04-09 18:15:35.724 | call(['ipset', 'restore', '-exist'],
run_as_root=True, process_input='create IPv4fake_sgid-new hash:ip family inet
hashsize 2048 maxelem 131072\nadd IPv4fake_sgid-new 10.0.0.1'),
2015-04-09 18:15:35.724 | call(['ipset', 'swap', 'IPv4fake_sgid-new',
'IPv4fake_sgid'], run_as_root=True, process_input=None),
2015-04-09 18:15:35.724 | call(['ipset', 'destroy',
'IPv4fake_sgid-new'], run_as_root=True, process_input=None),
2015-04-09 18:15:35.724 | call(['ipset', 'add', '-exist',
'IPv4fake_sgid', '10.0.0.3'], run_as_root=True, process_input=None),
2015-04-09 18:15:35.725 | call(['ipset', 'add', '-exist',
'IPv4fake_sgid', '10.0.0.2'], run_as_root=True, process_input=None)]
I think the fix for this is to just move the self.ipset
initializations from the base class into the sub-classes so they
operate on their own data independently of each other. Patch
forthcoming.
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1442377/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : [email protected]
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
