Reviewed: https://review.openstack.org/264097 Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=0632881948bbe37fb3638fa7a6c83f27e163302d Submitter: Jenkins Branch: master
commit 0632881948bbe37fb3638fa7a6c83f27e163302d Author: yangyapeng <yang.yap...@99cloud.net> Date: Mon Jan 4 17:35:17 2016 -0500 Change assertTrue(isinstance()) by optimal assert Some of tests use different method of assertTrue(isinstance(A, B)), The correct way is to use assertIsInstance(A,B) provided by testtools Change-Id: I3ae21a25e5fea904401d45d1a5de4db19c45169e Closes-bug: #1268480 ** Changed in: sahara Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1268480 Title: assertTrue(isinstance()) in tests should be replace with assertIsInstance() Status in Barbican: In Progress Status in Ceilometer: Fix Released Status in Cinder: In Progress Status in CloudRoast: In Progress Status in congress: Fix Released Status in Glance: Fix Released Status in heat: Fix Released Status in OpenStack Dashboard (Horizon): Fix Released Status in Ironic: Fix Released Status in ironic-python-agent: In Progress Status in OpenStack Identity (keystone): Fix Released Status in Manila: Fix Released Status in Mistral: Fix Released Status in Monasca: In Progress Status in Murano: In Progress Status in neutron: In Progress Status in OpenStack Compute (nova): Fix Released Status in python-ceilometerclient: Fix Released Status in python-cinderclient: Fix Released Status in python-glanceclient: Fix Released Status in python-ironicclient: Fix Released Status in python-keystoneclient: Fix Released Status in python-manilaclient: In Progress Status in python-novaclient: Fix Released Status in OpenStack SDK: Fix Released Status in python-tuskarclient: In Progress Status in Rally: In Progress Status in Sahara: Fix Released Status in OpenStack Object Storage (swift): In Progress Status in tempest: In Progress Status in Trove: Fix Released Bug description: some of tests use different method of assertTrue(isinstance(A, B)) or assertEqual(type(A), B). The correct way is to use assertIsInstance(A, B) provided by testtools To manage notifications about this bug go to: https://bugs.launchpad.net/barbican/+bug/1268480/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp