https://review.openstack.org/#/c/328051/
** Also affects: tap-as-a-service
Importance: Undecided
Status: New
** Changed in: tap-as-a-service
Status: New => In Progress
** Changed in: tap-as-a-service
Assignee: (unassigned) => YAMAMOTO Takashi (yamamoto)
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1590117
Title:
Service plugin class' get_plugin_type should be a classmethod
Status in networking-midonet:
In Progress
Status in neutron:
Fix Released
Status in tap-as-a-service:
In Progress
Bug description:
There isn't any reason to have it as an instance method as its only
returning a constant.
$ git grep 'def get_plugin_type('
neutron/extensions/metering.py: def get_plugin_type(self):
neutron/extensions/qos.py: def get_plugin_type(self):
neutron/extensions/segment.py: def get_plugin_type(self):
neutron/extensions/tag.py: def get_plugin_type(self):
neutron/services/auto_allocate/plugin.py: def get_plugin_type(self):
neutron/services/flavors/flavors_plugin.py: def get_plugin_type(self):
neutron/services/l3_router/l3_router_plugin.py: def get_plugin_type(self):
neutron/services/network_ip_availability/plugin.py: def
get_plugin_type(self):
neutron/services/service_base.py: def get_plugin_type(self):
neutron/services/timestamp/timestamp_plugin.py: def get_plugin_type(self):
neutron/tests/functional/pecan_wsgi/utils.py: def get_plugin_type(self):
neutron/tests/unit/api/test_extensions.py: def
get_plugin_type(self):
neutron/tests/unit/api/test_extensions.py: def
get_plugin_type(self):
neutron/tests/unit/dummy_plugin.py: def get_plugin_type(self):
neutron/tests/unit/extensions/test_flavors.py: def get_plugin_type(self):
neutron/tests/unit/extensions/test_l3.py: def get_plugin_type(self):
neutron/tests/unit/extensions/test_router_availability_zone.py: def
get_plugin_type(self):
neutron/tests/unit/extensions/test_segment.py: def get_plugin_type(self):
To manage notifications about this bug go to:
https://bugs.launchpad.net/networking-midonet/+bug/1590117/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
