Reviewed: https://review.openstack.org/326867 Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=39e387c182a5d713e17be4b77349a4472e73e7d6 Submitter: Jenkins Branch: master
commit 39e387c182a5d713e17be4b77349a4472e73e7d6 Author: YAMAMOTO Takashi <[email protected]> Date: Wed Jun 8 16:08:47 2016 +0900 Make get_plugin_type classmethod Following the recent Neutron change. [1] [1] Ia3a1237a5e07169ebc9378b1cd4188085e20d71c Closes-Bug: #1590117 Change-Id: I81f46ef6d855166240581d0f2843bd519d45c4a5 ** Changed in: networking-midonet Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1590117 Title: Service plugin class' get_plugin_type should be a classmethod Status in networking-midonet: Fix Released Status in neutron: Fix Released Status in tap-as-a-service: Fix Released Bug description: There isn't any reason to have it as an instance method as its only returning a constant. $ git grep 'def get_plugin_type(' neutron/extensions/metering.py: def get_plugin_type(self): neutron/extensions/qos.py: def get_plugin_type(self): neutron/extensions/segment.py: def get_plugin_type(self): neutron/extensions/tag.py: def get_plugin_type(self): neutron/services/auto_allocate/plugin.py: def get_plugin_type(self): neutron/services/flavors/flavors_plugin.py: def get_plugin_type(self): neutron/services/l3_router/l3_router_plugin.py: def get_plugin_type(self): neutron/services/network_ip_availability/plugin.py: def get_plugin_type(self): neutron/services/service_base.py: def get_plugin_type(self): neutron/services/timestamp/timestamp_plugin.py: def get_plugin_type(self): neutron/tests/functional/pecan_wsgi/utils.py: def get_plugin_type(self): neutron/tests/unit/api/test_extensions.py: def get_plugin_type(self): neutron/tests/unit/api/test_extensions.py: def get_plugin_type(self): neutron/tests/unit/dummy_plugin.py: def get_plugin_type(self): neutron/tests/unit/extensions/test_flavors.py: def get_plugin_type(self): neutron/tests/unit/extensions/test_l3.py: def get_plugin_type(self): neutron/tests/unit/extensions/test_router_availability_zone.py: def get_plugin_type(self): neutron/tests/unit/extensions/test_segment.py: def get_plugin_type(self): To manage notifications about this bug go to: https://bugs.launchpad.net/networking-midonet/+bug/1590117/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
