Reviewed: https://review.openstack.org/371742 Committed: https://git.openstack.org/cgit/openstack/neutron-dynamic-routing/commit/?id=b4c840d97b828c4f81c813f41f3de5f1355f2896 Submitter: Jenkins Branch: master
commit b4c840d97b828c4f81c813f41f3de5f1355f2896 Author: Armando Migliaccio <[email protected]> Date: Fri Sep 16 11:06:22 2016 -0700 Stop using _create_or_update_agent There is a public method, use it instead! Change-Id: Ie076a2860a54c5e2958c16593c3f39f86353cd34 Closes-bug: #1624496 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1624496 Title: _create_or_update_agent used by neutron-dynamic-routing Status in neutron: Fix Released Bug description: With change [1] we accidentally removed a private method, which is used by neutron-dynamic-routing. Furthermore, we tweaked the signature of the corresponding public method. This is really bad and should have not happened. No point in crying over spilled milk, [3] shows us that damage is not as bad as it sounds, and does not justify a revert for [1], but this warrants an RC2 for dynamic-routing, whose unit tests are currently broken for RC1. [1] https://review.openstack.org/#/c/367182/ [2] https://review.openstack.org/#/c/371680/ [3] http://codesearch.openstack.org/?q=create_or_update_agent&i=nope&files=&repos= To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1624496/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
