Reviewed: https://review.openstack.org/458923 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a15c84956366456683cd7e5227c5e244e15c3e6e Submitter: Jenkins Branch: master
commit a15c84956366456683cd7e5227c5e244e15c3e6e Author: Hunt Xu <[email protected]> Date: Sat Apr 22 01:08:48 2017 +0800 ProcessManager: honor run_as_root when stopping process Without this commit, the run_as_root parameter is always True when stopping a process, which leads to the usage of unnecessary sudo such as in some functional tests, like the keepalived ones. This commit fixes the aforemetioned problem by taking run_as_root into account when stopping a process. However, run_as_root will still always be True if the process is spawned in a netns. Closes-Bug: #1491581 Change-Id: Ib40e1e3357b9a38e760f4e552bf615cdfd54ee5a Signed-off-by: Hunt Xu <[email protected]> ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1491581 Title: Some functional tests use 'sudo' alone without rootwrap Status in neutron: Fix Released Bug description: While looking at functional tests console outputs Ihar noticed that some tests are executing 'sudo' without going through rootwrap. Example: http://logs.openstack.org/03/216603/4/check/gate-neutron-dsvm-functional/9ed19a4/console.html (CTRL-F for "['sudo'"). (Command: ['sudo', 'kill', '-15', '22920']). Patch https://review.openstack.org/#/c/114717/ added a gate hook for the Neutron functional job, and it's possible that since then we've been allowing 'naked sudo' at the functional gate, because stripping the 'stack' user from 'sudo' was previously being done by the gate_hook in the devstack_gate project. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1491581/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
