Reviewed: https://review.openstack.org/491346 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8275d67949915e9b600559787cdb05bb23fdf337 Submitter: Zuul Branch: master
commit 8275d67949915e9b600559787cdb05bb23fdf337 Author: Shu Muto <[email protected]> Date: Thu May 25 18:39:15 2017 +0900 Reproduce navigations on refreshing ngdetails view To setup proper navigation to side bar and breadcrumb, this patch adds new 'defaultIndexUrl' parameter and its getter/setter into resource-type-service. The 'defaultIndexUrl' parameter makes details view enable to set navigations properly in Angular-side. Each panel module should set URL for default index view using 'defaultIndexUrl' parameter. So, this patch adds the `defaultIndexUrl` parameter into existing panel modules that have Angularized details view. Also, if query string has 'nav' parameter, the navigation setting will be overwitten with it. This URL overwriting may be used by panels that has multiple index panels, like images panel. Change-Id: I2edd44e55eb10114e5282cec1762e9635881f733 Closes-Bug: #1746706 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1746706 Title: Navigation needs to be recovered when opening/reloading ngdetail page Status in OpenStack Dashboard (Horizon): Fix Released Bug description: Fix for bug 1681627 allows us to reload or directly open Angular-based detail page (ngdetail), but the navigation menu is not recovered correctly and the menu is focused on the first panel (Project -> API access in most cases). This bug is used to track this problem. There are several thing to be considered. * How to know which panel a ngdetail page belongs to. * How to know which dashboard a ngdetail page belongs to. Perhaps most tricky thing is that at now there is a cases where a single ngdetail page is linked from both the project and admin dashboard, but there is no good way to known the dashboard information from URL. In case of reloading it might be recovered from browser history, but it does not work for opening a ngdetail page via a direct URL. We might need to revisit URL of ngdetail page to include a dashboard information as we do for Django panels and Angular Index page. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1746706/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
