Reviewed: https://review.openstack.org/641759 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3e6bf09a70377f825b90637c6e2c6865933d9971 Submitter: Zuul Branch: master
commit 3e6bf09a70377f825b90637c6e2c6865933d9971 Author: Matt Riedemann <[email protected]> Date: Thu Mar 7 14:05:11 2019 -0500 Clean up block_device_allocate_retries config option help The "on failures" portion of this option's description does not make sense. It's not about failures, it's about how many times to check a volume that nova-compute created to be "available" before it can be attached to the server during boot from volume. So that is replaced and a new description is added explaining when and how this is used, and what happens on timeout. The old Liberty mention of the volume image cache is also replaced with a link to the cinder docs for that feature. Change-Id: Ic7ef9d44ec64c3d5834181bd8b61aae56858af81 Partial-Bug: #1819049 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1819049 Title: block_device_allocate_retries help needs work Status in OpenStack Compute (nova): Fix Released Bug description: The description of this option is confusing: https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.block_device_allocate_retries "Number of times to retry block device allocation on failures. Starting with Liberty, Cinder can use image volume cache. This may help with block device allocation performance. Look at the cinder image_volume_cache_enabled configuration option." The "on failures" part doesn't make sense. The option is used during boot from volume where nova-compute is waiting for volumes it created to be "available" before attaching them to the server. The mention of Liberty can also probably go away and just link to the cinder docs: https://docs.openstack.org/cinder/latest/admin/blockstorage-image- volume-cache.html It should also mention the related block_device_allocate_retries_interval option. Following up, a min=0 value could be added so the code doesn't need to handle values less than 0. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1819049/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
