Reviewed: https://review.opendev.org/c/openstack/nova/+/800313 Committed: https://opendev.org/openstack/nova/commit/87dba379aca6ec4613986cfa4e749a3ada2b44d0 Submitter: "Zuul (22348)" Branch: master
commit 87dba379aca6ec4613986cfa4e749a3ada2b44d0 Author: melanie witt <[email protected]> Date: Fri Jul 9 22:22:15 2021 +0000 Make test_archive_task_logs deterministic The 'nova-manage db archive_deleted_rows --task-log' functional tests involve manipulating time to assert archive behaviors when the --before flag is also used. While timedelta was used, set_time_override was not, so depending on the date the test ran on + the number of days in the current month and next two months, the test could fail. Task log audit periods are one calendar month by default and the compute manager calls last_completed_audit_period() without specifying a unit. This changes the tests to use a time override to ensure predictable behavior with regard to the audit period boundaries. The tests were moved into their own test case classes in order to override the time before services were started, so that the "service up" calculations work as expected. Closes-Bug: #1934519 Change-Id: I9b16a3a849937aba5b90ed1ab9a80b7f0103f673 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1934519 Title: nova.tests.functional.test_nova_manage.{TestDBArchiveDeletedRowsMultiCell, TestDBArchiveDeletedRows}.test_archive_task_logs failing Status in OpenStack Compute (nova): Fix Released Bug description: https://zuul.opendev.org/t/openstack/builds?job_name=nova-tox- functional-py38&project=openstack%2Fnova&branch=master&pipeline=check https://925ac014ce9affd643c5-922c284b53012421c7cb8203c60422be.ssl.cf2.rackcdn.com/780147/23/check/nova- tox-functional-py38/8da78ca/testr_results.html Traceback (most recent call last): File "/home/zuul/src/opendev.org/openstack/nova/nova/tests/functional/test_nova_manage.py", line 1735, in test_archive_task_logs self.assertRegex(self.output.getvalue(), r'\| task_log\s+\| 2') File "/home/zuul/src/opendev.org/openstack/nova/.tox/functional-py38/lib/python3.8/site-packages/unittest2/case.py", line 1304, in assertRegex raise self.failureException(msg) AssertionError: Regex didn't match: '\\| task_log\\s+\\| 2' not found in 'Nothing was archived.\n+----------+-------------------------+\n| Table | Number of Rows Archived |\n+----------+-------------------------+\n| task_log | 1 |\n+----------+-------------------------+\n+----------+-------------------------+\n| Table | Number of Rows Archived |\n+----------+-------------------------+\n| task_log | 1 |\n+----------+-------------------------+\n' To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1934519/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
