Reviewed: https://review.opendev.org/c/openstack/nova/+/803106 Committed: https://opendev.org/openstack/nova/commit/39ef1ad774859562183190f74831a115698e6836 Submitter: "Zuul (22348)" Branch: master
commit 39ef1ad774859562183190f74831a115698e6836 Author: melanie witt <[email protected]> Date: Sat Jul 31 15:49:12 2021 +0000 Restore original time override in test_archive_task_logs Change I9b16a3a849937aba5b90ed1ab9a80b7f0103f673 attempted to fix a non-determinstic failure in the test_archive_task_logs functional test by adding a time override. That fix however missed that the osloutils_fixture.TimeFixture clears the time override when it exits and that does not mean a previous time override will be restored. This removes usage of the osloutils_fixture.TimeFixture and instead sets time overrides and restores previous time overrides. Restoration of the original time overrides also made an adjustment to the --before option value necessary in order to pick up the first task_log record. Closes-Bug: #1934519 Change-Id: Ic28d2e53d5f50e89635e19df08699f2b8c5cea84 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1934519 Title: nova.tests.functional.test_nova_manage.{TestDBArchiveDeletedRowsMultiCell, TestDBArchiveDeletedRows}.test_archive_task_logs failing Status in OpenStack Compute (nova): Fix Released Bug description: https://zuul.opendev.org/t/openstack/builds?job_name=nova-tox- functional-py38&project=openstack%2Fnova&branch=master&pipeline=check https://925ac014ce9affd643c5-922c284b53012421c7cb8203c60422be.ssl.cf2.rackcdn.com/780147/23/check/nova- tox-functional-py38/8da78ca/testr_results.html Traceback (most recent call last): File "/home/zuul/src/opendev.org/openstack/nova/nova/tests/functional/test_nova_manage.py", line 1735, in test_archive_task_logs self.assertRegex(self.output.getvalue(), r'\| task_log\s+\| 2') File "/home/zuul/src/opendev.org/openstack/nova/.tox/functional-py38/lib/python3.8/site-packages/unittest2/case.py", line 1304, in assertRegex raise self.failureException(msg) AssertionError: Regex didn't match: '\\| task_log\\s+\\| 2' not found in 'Nothing was archived.\n+----------+-------------------------+\n| Table | Number of Rows Archived |\n+----------+-------------------------+\n| task_log | 1 |\n+----------+-------------------------+\n+----------+-------------------------+\n| Table | Number of Rows Archived |\n+----------+-------------------------+\n| task_log | 1 |\n+----------+-------------------------+\n' To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1934519/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
